Auto build gradle lib-project dependencies #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loosebazooka
force-pushed
the
multi-module-gradle
branch
2 times, most recently
from
91ab7cd
to
59293dd
Compare
Search through all configurations for dependencies of the style
'configurationName project(":path")' and have jib depend on the
'assemble' task of that project. This ensure jar dependencies
are built before jib starts to package the project.
loosebazooka
force-pushed
the
multi-module-gradle
branch
from
59293dd
to
55939ef
Compare
coollog
approved these changes
Aug 10, 2018
| dockerContextTask.dependsOn(classesTask); | ||
| buildDockerTask.dependsOn(classesTask); | ||
| buildTarTask.dependsOn(classesTask); | ||
| buildImageTask.dependsOn(taskDependencies.toArray()); |
There was a problem hiding this comment.
Can use setDependsOn to avoid toArray.
There was a problem hiding this comment.
That overwrites any previously dependencies.
For instance in a build.gradle like
apply plugin: 'jib'
task myCustomTask {
doLast {
// blah balh
}
}
jib.dependOn("myCustomTask")
the build using setDependsOn will not honor the myCustomTask dependency.
| * @param project this project we are containerizing | ||
| * @return a list of "assemble" tasks associated with projects that this project depends on. | ||
| */ | ||
| static List<Task> getProjectDependencyAssembleTasks(Project project) { |
There was a problem hiding this comment.
nit: Order above non-static and annotate with @VisibleForTesting.
coollog
approved these changes
Aug 10, 2018
| @@ -40,6 +40,42 @@ | |||
| @VisibleForTesting static final String BUILD_DOCKER_TASK_NAME = "jibDockerBuild"; | |||
| @VisibleForTesting static final String DOCKER_CONTEXT_TASK_NAME = "jibExportDockerContext"; | |||
|
|
|||
| private static void checkGradleVersion() { | |||
There was a problem hiding this comment.
nit: private static below package-private static
coollog
approved these changes
Aug 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Search through all configurations for dependencies of the style
'configurationName project(":path")' and have jib depend on the
'assemble' task of that project. This ensure jar dependencies
are built before jib starts to package the project.
Fixes #815