Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add labels to maven config #867

Merged
merged 5 commits into from
Aug 22, 2018
Merged

Add labels to maven config #867

merged 5 commits into from
Aug 22, 2018

Conversation

TadCordle
Copy link
Contributor

Part of #751

@briandealwis
Copy link
Member

briandealwis commented Aug 22, 2018 •
edited
Loading

One question — this will overwrite any labels from the base image, right? Should we be propagating them? (#595)

Nevermind: #804 does this.

@TadCordle TadCordle merged commit f61cf97 into master Aug 22, 2018
@TadCordle TadCordle deleted the maven-labels-config branch August 22, 2018 15:32
@loosebazooka loosebazooka mentioned this pull request Aug 22, 2018
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandealwis briandealwis briandealwis approved these changes

@loosebazooka loosebazooka Awaiting requested review from loosebazooka

@coollog coollog Awaiting requested review from coollog

@chanseokoh chanseokoh Awaiting requested review from chanseokoh

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TadCordle @briandealwis @googlebot