Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate WorkingDir in container configuration #902

Merged
merged 4 commits into from
Aug 30, 2018
Merged

Propagate WorkingDir in container configuration #902

merged 4 commits into from
Aug 30, 2018

Conversation

chanseokoh
Copy link
Member

Part of #595.

@chanseokoh
Copy link
Member Author

Ready for review.

coollog
coollog approved these changes Aug 29, 2018
View reviewed changes
jib-core/src/main/java/com/google/cloud/tools/jib/image/Image.java Outdated
@@ -135,6 +136,11 @@
return this;
}

public Builder<T> setWorkingDirectory(@Nullable String workingDirectory) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

javadoc here

@chanseokoh chanseokoh merged commit 9bfff0e into master Aug 30, 2018
@chanseokoh chanseokoh deleted the i431-i595-propagte-workingDir branch August 30, 2018 13:49
@chanseokoh chanseokoh mentioned this pull request Sep 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coollog coollog coollog approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chanseokoh @coollog @googlebot