Adds to.tags configuration for Gradle. #978
Conversation
coollog
changed the title
| @@ -190,6 +190,11 @@ public void testBuild_empty() throws IOException, InterruptedException { | |||
| new Command("docker", "inspect", "-f", "{{.Created}}", targetImage).run().trim()); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testBuild_multipleTags() throws IOException, InterruptedException { | |||
| // TODO: Implement | |||
There was a problem hiding this comment.
If this is to be implemented in a later PR, I'd remove it from here. It's just a test method, and I don't think we need a placeholder.
There was a problem hiding this comment.
Oh yea, I will implement this in this PR. I wanted to solicit some comments about the way BaseImageParameters and TargetImageParameters are laid out first.
| /** {@link ImageParameters} that configure the base image. */ | ||
| public class BaseImageParameters implements ImageParameters { | ||
|
|
||
| private AuthParameters auth; |
There was a problem hiding this comment.
Seems like this can be final.
| public ImageParameters(ObjectFactory objectFactory, String imageDescriptor) { | ||
| auth = objectFactory.newInstance(AuthParameters.class, imageDescriptor + ".auth"); | ||
| } | ||
| interface ImageParameters { | ||
|
|
||
| @Input |
There was a problem hiding this comment.
Is this @Input in effect in implementation classes? Should this be on implementation classes? (Not sure.)
There was a problem hiding this comment.
Yea I believe so, since it does not work without @Optional here (Gradle fails with jib.to.image not set), so that indicates that the annotations are inherited from the interface.
| } | ||
|
|
||
| @Override | ||
| public void auth(Action<? super AuthParameters> action) { |
There was a problem hiding this comment.
Does Action<AuthParameters> work?
There was a problem hiding this comment.
Yes that would work - is there a preference for using the specific type over allowing super types?
There was a problem hiding this comment.
This is not a public facing API, and I was wondering if there is anyone calling auth() with a type Action<AuthProperty> for example. Maybe I'm not familiar with Gradle idioms.
There was a problem hiding this comment.
This is for like the jib-gradle-plugin jib.to.auth configuration so that users can configure the auth for a base or target image. The actual action that Groovy generates for this may be just Action<AuthParameters>, but I guess someone could decide to use like an Action<Object> that did some arbitrary thing on the auth object.
There was a problem hiding this comment.
I think it might have something to do with gradle decorating things.
...in/src/integration-test/java/com/google/cloud/tools/jib/gradle/JibPluginIntegrationTest.java
Outdated
Show resolved
Hide resolved
|
Will merge master after #1019 to fix the failing tests. |
For #802 (comment)