-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #795 from GoogleContainerTools/tejal29-pr-template
Add a pull request template
- Loading branch information
Showing
1 changed file
with
41 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
<!-- πππ Thank you for the PR!!! πππ --> | ||
|
||
|
||
Fixes `#<issue number>`. _in case of a bug fix, this should point to a bug and any other related issue(s)_ | ||
|
||
**Description** | ||
|
||
<!-- Describe your changes here- ideally you can get that description straight from | ||
your descriptive commit message(s)! --> | ||
|
||
**Submitter Checklist** | ||
|
||
These are the criteria that every PR should meet, please check them off as you | ||
review them: | ||
|
||
- [ ] Includes [unit tests](../DEVELOPMENT.md#creating-a-pr) | ||
- [ ] Adds integration tests if needed. | ||
|
||
_See [the contribution guide](../CONTRIBUTING.md) for more details._ | ||
|
||
|
||
**Reviewer Notes** | ||
|
||
- [ ] The code flow looks good. | ||
- [ ] Unit tests and or integration tests added. | ||
|
||
|
||
**Release Notes** | ||
|
||
Describe any changes here so maintainer can include it in the release notes, or delete this block. | ||
|
||
``` | ||
Examples of user facing changes: | ||
- Skaffold config changes like | ||
e.g. "Add buildArgs to `Kustomize` deployer skaffold config." | ||
- Bug fixes | ||
e.g. "Improve skaffold init behaviour when tags are used in manifests" | ||
- Any changes in skaffold behavior | ||
e.g. "Artiface cachine is turned on by default." | ||
``` |