Skip to content

Commit

Permalink
Merge pull request #795 from GoogleContainerTools/tejal29-pr-template
Browse files Browse the repository at this point in the history
Add a pull request template
  • Loading branch information
donmccasland authored Sep 27, 2019
2 parents 51734fc + e311274 commit 09bf862
Showing 1 changed file with 41 additions and 0 deletions.
41 changes: 41 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
<!-- πŸŽ‰πŸŽ‰πŸŽ‰ Thank you for the PR!!! πŸŽ‰πŸŽ‰πŸŽ‰ -->


Fixes `#<issue number>`. _in case of a bug fix, this should point to a bug and any other related issue(s)_

**Description**

<!-- Describe your changes here- ideally you can get that description straight from
your descriptive commit message(s)! -->

**Submitter Checklist**

These are the criteria that every PR should meet, please check them off as you
review them:

- [ ] Includes [unit tests](../DEVELOPMENT.md#creating-a-pr)
- [ ] Adds integration tests if needed.

_See [the contribution guide](../CONTRIBUTING.md) for more details._


**Reviewer Notes**

- [ ] The code flow looks good.
- [ ] Unit tests and or integration tests added.


**Release Notes**

Describe any changes here so maintainer can include it in the release notes, or delete this block.

```
Examples of user facing changes:
- Skaffold config changes like
e.g. "Add buildArgs to `Kustomize` deployer skaffold config."
- Bug fixes
e.g. "Improve skaffold init behaviour when tags are used in manifests"
- Any changes in skaffold behavior
e.g. "Artiface cachine is turned on by default."
```

0 comments on commit 09bf862

Please sign in to comment.