Skip to content

Commit

Permalink
Integration tests for entrypoint
Browse files Browse the repository at this point in the history
  • Loading branch information
Priya Wadhwa committed Mar 20, 2018
1 parent d49c7c5 commit bf47ea9
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,6 @@ FROM gcr.io/distroless/base:latest
CMD ["command", "one"]
CMD ["command", "two"]
CMD echo "hello"

ENTRYPOINT ["execute", "something"]
ENTRYPOINT ["execute", "entrypoint"]
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
schemaVersion: '2.0.0'
metadataTest:
cmd: ["/bin/sh", "-c", "echo \"hello\""]
entrypoint: ["execute", "entrypoint"]
8 changes: 4 additions & 4 deletions integration_tests/integration_test_yaml.go
Original file line number Diff line number Diff line change
Expand Up @@ -66,11 +66,11 @@ var structureTests = []struct {
structureTestYamlPath: "/workspace/integration_tests/dockerfiles/test_env.yaml",
},
{
description: "test cmd",
dockerfilePath: "/workspace/integration_tests/dockerfiles/Dockerfile_test_cmd",
repo: "test-cmd",
description: "test metadata",
dockerfilePath: "/workspace/integration_tests/dockerfiles/Dockerfile_test_metadata",
repo: "test-metadata",
dockerBuildContext: "/workspace/integration_tests/dockerfiles/",
structureTestYamlPath: "/workspace/integration_tests/dockerfiles/test_cmd.yaml",
structureTestYamlPath: "/workspace/integration_tests/dockerfiles/test_metadata.yaml",
},
}

Expand Down
6 changes: 4 additions & 2 deletions pkg/commands/cmd.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,13 @@ func (c *CmdCommand) FilesToSnapshot() []string {

// CreatedBy returns some information about the command for the image config history
func (c *CmdCommand) CreatedBy() string {
cmd := []string{"CMD"}
cmdLine := strings.Join(c.cmd.CmdLine, " ")
if c.cmd.PrependShell {
// TODO: Support shell command here
shell := []string{"/bin/sh", "-c"}
return strings.Join(append(shell, cmdLine), " ")
appendedShell := append(cmd, shell...)
return strings.Join(append(appendedShell, cmdLine), " ")
}
return cmdLine
return strings.Join(append(cmd, cmdLine), " ")
}

0 comments on commit bf47ea9

Please sign in to comment.