refactor copy.chown code and add more tests #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejal29
changed the title
tejal29
force-pushed
the
small_refacto
branch
from
7f489a9
to
d94a1ed
Compare
cvgw
reviewed
Feb 7, 2020
| } | ||
| chown, err := util.ResolveEnvironmentReplacement(chownStr, env, false) | ||
| if err != nil { | ||
| return -1, -1, err |
There was a problem hiding this comment.
Why -1 and not util.DoNotChangeUID ?
There was a problem hiding this comment.
The return value here should be ignored since err is not nil.
I did not use the util.DoNotChangeUID since the return value does not matter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring code in #962 and adding more tests