Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor integration image built #1049

Merged
merged 1 commit into from
Feb 26, 2020
Merged

Refactor integration image built #1049

merged 1 commit into from
Feb 26, 2020

Conversation

antechrestos
Copy link
Contributor

Description

The aim of this change is to hide the complexity of image not being rebuilt. Image builder won't also have to know the list of dockerfiles

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes [unit tests] Not needed
  • Adds integration tests if needed.Not needed

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

@googlebot googlebot added the cla: yes CLA signed by all commit authors label Feb 13, 2020
integration/images.go Outdated Show resolved Hide resolved
@samos123 samos123 changed the title Refactor integration imaqge built Refactor integration image built Feb 15, 2020
The aim of this change is to hide the complexity of image not being rebuilt. Image builder won't also have to know the list of dockerfiles
@antechrestos
Copy link
Contributor Author

@cvgw @tejal29 I was approved . I can be merged 👼

@tejal29 tejal29 merged commit fb0cfd7 into GoogleContainerTools:master Feb 26, 2020
@antechrestos antechrestos deleted the refactor/build_cache_in_integration_image_build branch February 26, 2020 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA signed by all commit authors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants