Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests from Issues #1054

Conversation

cvgw
Copy link
Contributor

@cvgw cvgw commented Feb 14, 2020

Description

Adds new integration tests collected from some of the GH issues

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

@googlebot googlebot added the cla: yes CLA signed by all commit authors label Feb 14, 2020
@cvgw cvgw force-pushed the u/cgwippern/integration-tests-from-issues branch from 6ae36e8 to 4ed1a9c Compare February 14, 2020 17:09
@cvgw cvgw changed the title U/cgwippern/integration tests from issues Add integration tests from Issues Feb 14, 2020
@tejal29 tejal29 force-pushed the u/cgwippern/integration-tests-from-issues branch from 4ed1a9c to 9f18d80 Compare February 27, 2020 19:05
This is the max job execution time that travis free tier supports
@cvgw cvgw requested a review from tejal29 March 1, 2020 05:03
@samos123
Copy link
Contributor

samos123 commented Mar 2, 2020

It seems this pull request isn't needed since these changes area already included in your bigger pull request: #1088

@cvgw
Copy link
Contributor Author

cvgw commented Mar 2, 2020 via email

@cvgw cvgw requested a review from samos123 March 3, 2020 16:48
@cvgw cvgw merged commit 17ceb31 into GoogleContainerTools:master Mar 3, 2020
@cvgw cvgw deleted the u/cgwippern/integration-tests-from-issues branch March 3, 2020 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA signed by all commit authors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants