Fix #1020 os.Chtimes invalid arg #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvgw
force-pushed
the
u/cgwippern/fix-1020-chtimes-invalid-arg
branch
2 times, most recently
from
6db7201
to
6130e90
Compare
The zero value of time.Time is not a valid argument to os.Chtimes because of the syscall that os.Chtimes calls. Instead we update the zero value of time.Time to the zero value of Unix Epoch
cvgw
force-pushed
the
u/cgwippern/fix-1020-chtimes-invalid-arg
branch
from
6130e90
to
60e2187
Compare
tejal29
approved these changes
Feb 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1020
Description
The zero value of time.Time is not a valid argument to os.Chtimes because of the syscall that os.Chtimes calls. Instead we update the zero value of time.Time to the zero value of Unix Epoch
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes