Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1092 TestRelativePaths #1093

Conversation

cvgw
Copy link
Contributor

@cvgw cvgw commented Mar 1, 2020

Fixes #1092

Description

Fix integraton test TestRelativePaths which previous failed to build or build the example with docker

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

@googlebot googlebot added the cla: yes CLA signed by all commit authors label Mar 1, 2020
@cvgw cvgw force-pushed the u/cgwippern/1092-fix-TestRelativePaths branch from bb51945 to df2b170 Compare March 1, 2020 04:58
Fix integraton test TestRelativePaths
@cvgw cvgw force-pushed the u/cgwippern/1092-fix-TestRelativePaths branch from df2b170 to 75f6bfe Compare March 1, 2020 05:16
@cvgw cvgw requested a review from tejal29 March 1, 2020 05:39
@tejal29 tejal29 merged commit a52a228 into GoogleContainerTools:master Mar 2, 2020
@cvgw cvgw deleted the u/cgwippern/1092-fix-TestRelativePaths branch March 2, 2020 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA signed by all commit authors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration TestRelativePaths fails to build
4 participants