Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests for Copy and some fixes. #1114

Merged
merged 6 commits into from
Mar 10, 2020

Conversation

tejal29
Copy link
Member

@tejal29 tejal29 commented Mar 7, 2020

Fixes to #1111 , #1110
In #1111, @gilbsgilbs metioned, copy symlink files should not be evaluated.

I started testing what docker build does and found

  1. docker build creates symlinks when copying a single file which is a symlink
    see Dockerfile COPY from image resolves symbolic links moby/moby#40449
  2. docker build preserves the symlink when copying a dir.

Kaniko, copy command was always creating a regular file.

While adding tests for copyCommand i found few issues.

  1. If dest was a directory in the context workspace, it wasn't identified as dir.
  2. Missed errors.Wrap that i found while debuging issues.

Please see all the scenarios tested with docker build here #1111 (comment)

@googlebot googlebot added the cla: yes CLA signed by all commit authors label Mar 7, 2020
@tejal29 tejal29 changed the title Add more tests for Copy and some minor fixes. Add more tests for Copy and some fixes. Mar 10, 2020
@tejal29 tejal29 merged commit c718dc6 into GoogleContainerTools:master Mar 10, 2020
@tejal29 tejal29 deleted the fix_copy branch April 26, 2021 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA signed by all commit authors kokoro:run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants