Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support of local '.tar.gz' file inside the kaniko container #1115

Conversation

JordanGoasdoue
Copy link
Contributor

@JordanGoasdoue JordanGoasdoue commented Mar 7, 2020

Fixes #567

Description

feat: add support of local build context format file : '.tar.gz' inside the kaniko container

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

  • kaniko allow a new build context tar://path/to/.tar.gz to use in kaniko container

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no CLA not signed by all commit authors label Mar 7, 2020
@JordanGoasdoue
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes CLA signed by all commit authors and removed cla: no CLA not signed by all commit authors labels Mar 7, 2020
@JordanGoasdoue JordanGoasdoue changed the title feat: add support of local '.tar.gz' file inside the kaniko container [WIP] feat: add support of local '.tar.gz' file inside the kaniko container Mar 7, 2020
@JordanGoasdoue JordanGoasdoue changed the title [WIP] feat: add support of local '.tar.gz' file inside the kaniko container feat: add support of local '.tar.gz' file inside the kaniko container Mar 8, 2020
@JordanGoasdoue JordanGoasdoue force-pushed the allow-build-context-from-local-targz branch 11 times, most recently from b3d67bf to f3d6b23 Compare March 8, 2020 16:50
pkg/buildcontext/file.go Outdated Show resolved Hide resolved
pkg/constants/constants.go Outdated Show resolved Hide resolved
Copy link
Contributor

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this feature!! this is looking great. just few comments,.

pkg/buildcontext/buildcontext.go Outdated Show resolved Hide resolved
integration/integration_test.go Outdated Show resolved Hide resolved
@JordanGoasdoue JordanGoasdoue force-pushed the allow-build-context-from-local-targz branch 3 times, most recently from ae03f88 to dd2ef60 Compare March 12, 2020 07:25
@JordanGoasdoue JordanGoasdoue changed the title feat: add support of local '.tar.gz' file inside the kaniko container (Wip) feat: add support of local '.tar.gz' file inside the kaniko container Mar 12, 2020
@JordanGoasdoue JordanGoasdoue force-pushed the allow-build-context-from-local-targz branch 3 times, most recently from 78df15b to 785b390 Compare March 12, 2020 14:21
@JordanGoasdoue JordanGoasdoue force-pushed the allow-build-context-from-local-targz branch 5 times, most recently from 1f92947 to 94fc2aa Compare March 12, 2020 20:21
@JordanGoasdoue JordanGoasdoue changed the title (Wip) feat: add support of local '.tar.gz' file inside the kaniko container feat: add support of local '.tar.gz' file inside the kaniko container Mar 12, 2020
@JordanGoasdoue
Copy link
Contributor Author

Thank you very much for your comments and review @tejal29 . It's a pleasure for me to finally contribute here.

It's working now with the unit tests, you can review again 👌

Cheers

@JordanGoasdoue JordanGoasdoue force-pushed the allow-build-context-from-local-targz branch from 94fc2aa to fda7ed4 Compare March 12, 2020 21:51
@JordanGoasdoue JordanGoasdoue requested a review from tejal29 March 13, 2020 07:08
@tejal29 tejal29 merged commit a173bf0 into GoogleContainerTools:master Mar 17, 2020
@tejal29
Copy link
Contributor

tejal29 commented Mar 17, 2020

Verified this manually by creating context.tar.
Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA signed by all commit authors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow .tgz for local context
3 participants