Travis k8s integration test #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we recently started adding more scripts it makes sense to move to a separate directory. This aligns with a common practice across golang projects: https://github.com/golang-standards/project-layout
- Use minikube for deploying a lightweight K8s on Travis CI - Build and push Kaniko image to local docker registry - Build dockerfiles with context on both docker and K8s and check the diff between the 2.
medyagh
reviewed
Mar 16, 2020
| sudo apt-get update | ||
| sudo apt-get install -y liblz4-tool | ||
|
|
||
| sudo minikube start --vm-driver=none |
There was a problem hiding this comment.
looks good to me, you could also use docker driver which doesnt need sudo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the diff between the 2.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes