fix previous name checking in 'executor.build.fetchExtraStages'

[antechrestos]

Description

Fixes minor bug in fetchExtraStages function. The continueinstruction only breaks the inner for loop instead of the outer one. (see example of two for loop and a continue in inner one)

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes [unit tests]
• Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

• The code flow looks good.
• Unit tests and or integration tests added.

[gilbsgilbs]

Definitely not a golang expert here, but pretty sure you could use a continue statement with label instead of a boolean flag.

[antechrestos]

@gilbsgilbs I am not a golang expert either, however I've been instructed not to ever use a label .. Out of machine language, I guess. A better solution would be to isolate this piece of code in a dedicated function I guess

[antechrestos]

I isolated this code in a dedicated function. Great profile picture by the way 😄

[antechrestos]

@tejal29 Guess I was right to wait as retrying the build with the current code works. This change is a minor one...Do I need to add some unit test?

[tejal29]

@antechrestos this is very minor and small refactor. You don't need to add tests!

[antechrestos]

thanks