optimize: don't parse Dockerfile twice, reusing stages #1174
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Planning to refactor a bit to work on issue #533, this one is just doing preparation refactoring that is out of scope for that issue.
CalculateDependencies()
, which parsing the Dockerfile again into kanikoStages, even though we already have them.command_utils.UpdateConfigEnv()
so that it will only update the config with the state of the existing environment variables, but will not modify the cmd.Env object itself. It prevents escaping the same ENV command twice (during calculateDependencies, and ExecuteCommand).Submitter Checklist*
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes
Describe any changes here so maintainer can include it in the release notes, or delete this block.