pkg: prepend library when using registry mirror #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
was #1261 |
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
|
@greut Can you please add some tests? |
|
@tejal29 what do I get? |
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
|
The same question, any progress? |
tejal29
approved these changes
Jul 28, 2020
|
@greut and @zhangfei9734 sorry for the delay. |
@greut please see our contribution guidelines #Contribution guidelines and our PR template https://github.com/GoogleContainerTools/kaniko/blob/master/.github/pull_request_template.md. In order to add maintainability and avoid future regressions, unit tests are good. |
|
@tejal29 Thanks mate! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1172
Description
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes
Describe any changes here so maintainer can include it in the release notes, or delete this block.