Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Reduce loops over files when taking FS snapshot. #1283

Merged
merged 2 commits into from
Jun 4, 2020

Conversation

tejal29
Copy link
Contributor

@tejal29 tejal29 commented May 23, 2020

Fixes #1282
Collapse 2 loop which walked over a list of all files into 1.
For large file systems, this will save some time.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

perf optimization for large projects.

@googlebot googlebot added the cla: yes CLA signed by all commit authors label May 23, 2020
@tejal29 tejal29 merged commit 86d77d8 into GoogleContainerTools:master Jun 4, 2020
@tejal29 tejal29 added the area/performance issues related to kaniko performance enhancement label Aug 22, 2020
@tejal29 tejal29 deleted the fix_looping branch April 26, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/performance issues related to kaniko performance enhancement cla: yes CLA signed by all commit authors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snapshotting is taking more than 10 mins.
2 participants