Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: accept GIT_TOKEN #1318

Merged
merged 5 commits into from
Aug 13, 2020
Merged

feat: accept GIT_TOKEN #1318

merged 5 commits into from
Aug 13, 2020

Conversation

caarlos0
Copy link
Contributor

@caarlos0 caarlos0 commented Jun 15, 2020

Description

Passing the token as GIT_USERNAME is a bit confusing to me, so I added support to a GIT_TOKEN, which if present will override GIT_USERNAME and set GIT_PASSWORD to empty.

Also changed README to reflect this change.

refs #1263

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

- feat: allows to set GIT_TOKEN to be used while cloning a repository

Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@googlebot googlebot added the cla: yes CLA signed by all commit authors label Jun 15, 2020
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@tejal29 tejal29 closed this Jul 29, 2020
@tejal29 tejal29 reopened this Jul 29, 2020
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@tejal29 tejal29 merged commit d83338e into GoogleContainerTools:master Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA signed by all commit authors kokoro:run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants