Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new git flags #1322

Merged
merged 7 commits into from
Aug 13, 2020
Merged

feat: new git flags #1322

merged 7 commits into from
Aug 13, 2020

Conversation

caarlos0
Copy link
Contributor

Closes #1321

Description

WIP adding --git-branch, --git-single-branch and --git-recurse-submodules flags, which work as their counterparts on git.

This is a PoC, haven't added tests yet because I'm looking for feedback on the impl first...

Also, this is based on more recent versions of go-git, hence I based it on #1319.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

- kaniko adds a new flag `--git-branch` to set which branch/tag to be cloned
- kaniko adds a new flag `--git-single-branch` to clone a single branch
- kaniko adds a new flag `--git-recurse-submodules` to change submodule recursions behavior while cloning

Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@googlebot googlebot added the cla: yes CLA signed by all commit authors label Jun 15, 2020
@caarlos0 caarlos0 changed the title Opts feat: new git flags Jun 15, 2020
cmd/executor/cmd/root.go Outdated Show resolved Hide resolved
caarlos0 added 2 commits June 24, 2020 15:10
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@tejal29
Copy link
Contributor

tejal29 commented Aug 12, 2020

LGTM!

@caarlos0 caarlos0 marked this pull request as ready for review August 13, 2020 12:41
@tejal29 tejal29 merged commit 0c7e164 into GoogleContainerTools:master Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
candidate-release cla: yes CLA signed by all commit authors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

git: mimic --branch and --single-branch git clone flags
3 participants