-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: Reproducible layers with whiteout #1350
Bugfix: Reproducible layers with whiteout #1350
Conversation
When deleting files of previous layers, the whiteout files were not added to the tar file in a consistent order. This change adds a stable sorting to the whiteout files and adds unit tests to check for stable sorting.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
filesInTars := [][]string{} | ||
|
||
for i := 0; i <= 2; i++ { | ||
testDir, snapshotter, cleanup, err := setUpTest() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is not ideal (using defer in a loop) and the non-determinism is a little hard to understand (converting from a map to a slice). But I chose to impolement the new tests like TestSnasphotPreservesFileOrder
for consistency.
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Fixes #900 (which was not fully solved).
Description
When deleting files of previous layers, the whiteout files
were not added to the tar file in a consistent order.
This change adds a stable sorting to the whiteout files and
adds unit tests to check for stable sorting.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes
No user facing changes.