Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Vagrant #1428

Merged
merged 2 commits into from
Sep 30, 2020
Merged

Conversation

martint17r
Copy link
Contributor

Description

Use the Vagrantfile to create a workable test machine in a few minutes
to run the unit and most of the integration tests on non-Linux systems.

I tried to contribute to kaniko but did not manage to make the tests pass on macOS (as there is no /proc mount). I first tried to create a Dockerfile, but the integration tests won't run with Docker Desktop because they can't mount the workspace for kaniko when building the images. After that I converted the Dockerfile to Vagrant

The integration tests pass individually, but the kubernetes stuff fails. I failed to find documentation on how to set that up. If you give me a pointer I would be happy to add kind or find another way to run them as well.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • [n/a] Includes unit tests
  • [n/a] Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Use the Vagrantfile to create a workable test machine in a few minutes
to run the unit and most of the integration tests on non-Linux systems.
@googlebot googlebot added the cla: yes CLA signed by all commit authors label Sep 17, 2020
@tejal29 tejal29 merged commit e18d823 into GoogleContainerTools:master Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA signed by all commit authors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants