fix docker-credential-gcr helper being called for multiple registries #1439
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in this Pr,
--registries
flag and--include-artifact-registry
when we run
docker-credential-gcr --registries=<first_registry>
docker config file is written at/kaniko/.docker/config.json
file is produced. Because the docker config file exists, we never rundocker-credential-gcr
for subsequent registries.Test done.
Yes,
I tested locally
Verified an image uploaded to my artifactory.
https://screenshot.googleplex.com/6s3MAZ6kzPit3ir