Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add https tar.gz remote source for context #1519

Merged
merged 3 commits into from
Dec 11, 2020

Conversation

jfrabaute
Copy link
Contributor

Description

Add remote https tar.gz source for the context.
The context could be on a remote tar.gz file accessible through an https server.
This is the case for example when having the source code in gerrit and using gitiles as a gerrit plugin so it's possible to get the code for an exact commit in tar.gz format.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

Examples of user facing changes:
- kaniko adds a new flag `--registry-repo` to override registry

@google-cla
Copy link

google-cla bot commented Dec 10, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no CLA not signed by all commit authors label Dec 10, 2020
@jfrabaute
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes CLA signed by all commit authors and removed cla: no CLA not signed by all commit authors labels Dec 10, 2020
@jfrabaute
Copy link
Contributor Author

Hi,

I didn't see there is an issue opened for this as well: #1464

Thanks.

@tejal29
Copy link
Contributor

tejal29 commented Dec 10, 2020

@jfrabaute Can you please add the missing license header?

@jfrabaute
Copy link
Contributor Author

@jfrabaute Can you please add the missing license header?

Looks like you sent a fix with the license header. Sorry about that.

Thanks!

@tejal29
Copy link
Contributor

tejal29 commented Dec 10, 2020

no worries. Sorry, i should i have waited.

@tejal29 tejal29 merged commit 454910f into GoogleContainerTools:master Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA signed by all commit authors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants