Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --image-name-tag-with-digest flag #1541

Merged
merged 1 commit into from
Jan 19, 2021

Conversation

Or-Geva
Copy link
Contributor

@Or-Geva Or-Geva commented Jan 7, 2021

Description
Added --image-name-tag-with-digest-file to write image:tag@sha256:... names based on destinations specified.

New flag will write a line for each destination specified. This is the full image path (ie, a docker registry will start with index.docker.io/{USER}/{IMAGE}:{TAG}@sha256:__)

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

Examples of user facing changes:
- kaniko adds a new flag `--image-name-tag-with-digest-file` to specify a file to save the image name w/ image tag and digest of the built image to.


@google-cla
Copy link

google-cla bot commented Jan 7, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no CLA not signed by all commit authors label Jan 7, 2021
@Or-Geva
Copy link
Contributor Author

Or-Geva commented Jan 7, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes CLA signed by all commit authors and removed cla: no CLA not signed by all commit authors labels Jan 7, 2021
@Or-Geva Or-Geva changed the title feat: add a flag to add image tag to '--image-name-with-digest-file' … Add --image-name-tag-with-digest flag Jan 8, 2021
@tejal29 tejal29 merged commit b3e036a into GoogleContainerTools:master Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA signed by all commit authors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants