Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying a tarPath will push the image as well #1597

Merged
merged 1 commit into from
Mar 31, 2021

Conversation

larsgroeber
Copy link
Contributor

Fixes #1544

Description

The README specifies that adding --tarPath will create a tarball but also push the image to the registry.

In my opinion this behaviour would be expected since the --no-push option exists.

I updated the push.go file so that it will only check for errors returned by the tarball generation instead of returning from there.

Unfortunately there is no unit test for the tarball generation (that I could find), and I did not feel comfortable enough with the code to add one myself.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

- updates the way the `--tarPath` option works, it now pushes the image as well

* Specifying a tarPath will push the image as well
@google-cla google-cla bot added the cla: yes CLA signed by all commit authors label Mar 10, 2021
@stevehipwell
Copy link

Could we get this merged ASAP?

@tejal29 tejal29 merged commit 0477900 into GoogleContainerTools:master Mar 31, 2021
@ManuelLR
Copy link

ManuelLR commented Apr 9, 2021

hey, this has been merged but is there any plan to make a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA signed by all commit authors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When --tarPath option is used, image is not uploaded to the registry
4 participants