Fix the e2e K8s test #1842
Merged
Fix the e2e K8s test #1842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmoor
force-pushed
the
fix-e2e
branch
2 times, most recently
from
c755a97
to
75dff85
Compare
It seems to be consistently failing (also fix a typo in the file/leg name). I'm disabling `-v` for `go test` because it interleaves the test output in ways that make it painful to read a single failing test's output when `t.Parallel` is involved.
mattmoor
force-pushed
the
fix-e2e
branch
7 times, most recently
from
47b33d0
to
81cf500
Compare
|
Trying a YOLO revert to the old minikube setup, which used |
mattmoor
force-pushed
the
fix-e2e
branch
4 times, most recently
from
c2c1cf3
to
6adda00
Compare
mattmoor
changed the title
imjasonh
approved these changes
Dec 17, 2021
|
amazing!! 馃帀 馃コ |
gcalmettes
pushed a commit
to gcalmettes/kaniko
that referenced
this pull request
Dec 24, 2021
* Debugging the integration testing. It seems to be consistently failing (also fix a typo in the file/leg name). I'm disabling `-v` for `go test` because it interleaves the test output in ways that make it painful to read a single failing test's output when `t.Parallel` is involved. * Try swapping registry:2 for the registry add-on * Drop logf and make Logger private
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The K8s e2e test has been failing since the move to actions. This adds a bunch of instrumentation I used to track down the failure. The biggest change was trying to consolidate test output to go through
t.Logso that the logs are properly correlated. I disabled-vbecause I find the resulting interleaving to be incredibly difficult to parse the failures out of.The crux of the issue was that the kaniko images were in ErrImgPull because the registry wasn't visible to the cluster. This was fixed by migrating to the minikube registry addon, but the next problem was that hostPath wasn't working properly with the
--driver=docker. So I migrated back to what was being successfully used on Travis and 馃帀 things pass.The main "fix" was a few parts:
registry:2,Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes