Attempt to speed up PR image builds by sharing a cache #1844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docker/setup-buildx-action actually provides first-class support for the GitHub Actions cache (though experimental). This should make builds much faster. Previous configuration wasn't properly configuring caching, as far as I can tell. This also takes advantage of GitHub Actions matrix support to more concisely express the build parameters then execute the same steps on them, which makes it clearer that the builds are all fundamentally doing the same thing.
imjasonh
force-pushed
the
actions-cache
branch
from
083736b
to
a3f7bcd
Compare
|
This seems to have worked in speeding up the builds, comparing attempt 1 and 2 (both successful). The fastest image (warmer) went from 21m -> 16m. The slowest image (executor-slim, with the most platforms) went from 59m -> 52m 🐢 It's still not really clear to me why these images are built on PRs if they're not pushed, but if we're going to do it we might as well do it as quickly as we can. If there's interest in making the builds even faster I can investigate it. |
|
cc @priyawadhwa After this I'd love to refactor pr_release.yaml and release.yaml so they share a lot more, maybe even become the same config with conditional steps. |
gcalmettes
pushed a commit
to gcalmettes/kaniko
that referenced
this pull request
Dec 24, 2021
…erTools#1844) docker/setup-buildx-action actually provides first-class support for the GitHub Actions cache (though experimental). This should make builds much faster. Previous configuration wasn't properly configuring caching, as far as I can tell. This also takes advantage of GitHub Actions matrix support to more concisely express the build parameters then execute the same steps on them, which makes it clearer that the builds are all fundamentally doing the same thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker/setup-buildx-action actually provides first-class support for
the GitHub Actions cache (though experimental). This should make builds
much faster. Previous configuration wasn't properly configuring caching,
as far as I can tell.
This also takes advantage of GitHub Actions matrix support to more
concisely express the build parameters then execute the same steps on
them, which makes it clearer that the builds are all fundamentally doing
the same thing.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes
NONE