Consolidate PR and real release workflows #1845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- push and sign an image tagged for every push to the repo (e.g., merged PRs) - push and sign for tag pushes, with release tags - build but don't push for opened PRs WIP because I need to test more with the tag flow, but pushes worked in my fork.
mattmoor
reviewed
Dec 18, 2021
mattmoor
reviewed
Dec 18, 2021
mattmoor
reviewed
Dec 18, 2021
Comment on lines
+76
to
+78
| # https://github.com/docker/build-push-action/blob/master/docs/advanced/cache.md#github-cache | ||
| cache-from: type=gha | ||
| cache-to: type=gha,mode=max |
There was a problem hiding this comment.
Can we avoid the cache on releases?
There was a problem hiding this comment.
That feels a bit overly paranoid, but sure. Is there some public guidance around building release without caches that I can link to in a comment?
There was a problem hiding this comment.
It’s a strict interpretation of some of the higher SLSA levels, and one build being able to influence others.
mattmoor
reviewed
Dec 20, 2021
mattmoor
reviewed
Dec 20, 2021
mattmoor
reviewed
Dec 20, 2021
mattmoor
reviewed
Dec 20, 2021
|
one small bug and a nit, but otherwise LGTM |
mattmoor
approved these changes
Dec 20, 2021
|
I can't check the reviewer boxes, since I'm not a maintainer, so cc @priyawadhwa |
imjasonh
changed the title
gcalmettes
pushed a commit
to gcalmettes/kaniko
that referenced
this pull request
Dec 24, 2021
* WIP: consolidate PR and real release workflows - push and sign an image tagged for every push to the repo (e.g., merged PRs) - push and sign for tag pushes, with release tags - build but don't push for opened PRs WIP because I need to test more with the tag flow, but pushes worked in my fork. * apply release tags, uncomment kms stuff * Tag images correctly during releases * review feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WIP because I'm pushing to GHCR to test for now.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes
cc @mattmoor @priyawadhwa