Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log full image ref by digest when pushing an image #1857

Merged
merged 1 commit into from
Dec 28, 2021

Conversation

imjasonh
Copy link
Collaborator

Description

Before:

INFO[0000] Pushing image to gcr.io/imjasonh/kaniko-built
INFO[0002] Pushed image to 1 destinations               

After:

INFO[0003] Pushed gcr.io/imjasonh/kaniko-built@sha256:b5429ceebb9d2345070526b8ce0ee897e3934a341f4fd18703266784deb877c1 

Without this change there's no clear way to determine the full digest of the image that Kaniko pushed, except maybe by using --oci-layout-path and inspecting the resulting layout.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

Kaniko now logs the full image ref including digest when it successfully pushes an image.

@dlorenc dlorenc merged commit 129df24 into GoogleContainerTools:master Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants