fix: change the name of the acr cred helper

[ankitm123]

Signed-off-by: ankitm123 ankitmohapatra123@gmail.com

fixes #1864

Description

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes unit tests
• Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

• The code flow looks good.
• Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

Fix issues with kaniko unable to push images to Azure Container registry. 

[imjasonh]

Thanks!

This indicates the lack of an integration test that exercises the ACR cred helper 🤔

[ankitm123]

For integration testing, wont this require an azure cluster? We dont have one for Jenkins X atm, which is the reason we caught it late. Are there tests for ecr/gcp that I can take a look at? I did not see them in the integration folder ...

[imjasonh]

For integration testing, wont this require an azure cluster? We dont have one for Jenkins X atm, which is the reason we caught it late. Are there tests for ecr/gcp that I can take a look at? I did not see them in the integration folder ...

Ideally yes, but that's probably going to be a nightmare to manage and setup and maintain auth for. Short of that, a test that just trivially called the helper with --help would have caught this bug. That wouldn't catch real auth bugs, but it's better than nothing.

This change lgtm and we should merge it, but I'd love to have better smoke tests for this in a future PR.

[ankitm123]

I guess we can just make it run the help command, that should prevent this issue in the future, wdyt?

EDIT: saw ur message, yes, help would be good!