Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KANIKO_REGISTRY_MIRROR env var #1875

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

imjasonh
Copy link
Collaborator

@imjasonh imjasonh commented Jan 7, 2022

Fixes #1752

Description

This adds support for checking a KANIKO_REGISTRY_MIRROR env var. If the env var is set, any value passed via --registry-mirror is ignored, and the env var value is used instead.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

Add KANIKO_REGISTRY_MIRROR env var to override/set --registry-mirror flag

@dlorenc dlorenc merged commit 1a6b8ce into GoogleContainerTools:main Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

registry-mirror setting in /kaniko/.docker/config.json
2 participants