Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick up per-repository auth changes from go-containerregistry #1939

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

imjasonh
Copy link
Collaborator

@imjasonh imjasonh commented Feb 14, 2022

Fixes #687

This picks up changes to auth config processing so that you can use a different username+password to auth to different repositories in the same registry, e.g.:

{
    "auths": {
        "example.com/registryA": { // Pull
            "username": "userA",
            "password": "passA"
        },
        "example.com/registryB": { // Push
            "username": "userB",
            "password": "passB"
        }
    }
}

This also picks up some log spam fixes when Google auth is not configured and not used.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

Accept per-repository auth configured in ~/.docker/config.json, in addition to per-registry auth

@imjasonh imjasonh merged commit 09e70e4 into GoogleContainerTools:main Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kaniko supporting multiple auths
2 participants