Fix image tags in release workflow #1977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two bugs: - fix typo in debug release_tag (should be release-tag) - only tag :latest images as :v1.X.Y; tag non-:latest images as :v1.X.Y-debug etc.
tejal29
reviewed
Mar 10, 2022
| @@ -43,7 +43,7 @@ jobs: | |||
| platforms: linux/amd64,linux/arm64,linux/s390x | |||
There was a problem hiding this comment.
Not part of your change, Is there a reason we don't have linux/ppc64le for executor-debug?
There was a problem hiding this comment.
They were all removed in #1784 but I'm not sure why. When the others were re-added there was some issue with the debug image and BusyBox I think, so it wasn't added.
tejal29
approved these changes
Mar 10, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two bugs:
:v1.X.Y-debug etc.
This should fix the issues reported in #1871 (comment) for future releases, which have been manually fixed for v1.8.0 in the meantime.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes