Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SVG logos #2002

Merged
merged 1 commit into from
Mar 21, 2022
Merged

Add SVG logos #2002

merged 1 commit into from
Mar 21, 2022

Conversation

sisp
Copy link
Contributor

@sisp sisp commented Mar 21, 2022

Description

I've added SVG images for both logos and re-exported the corresponding PNG images based on the SVGs for them to be in sync. The SVGs are not pixel-identical with the original PNGs:

  • The "K" in the rounded square was not perfectly vertically centered, I've fixed that.
  • The curved lines in the "K" in the rounded square had varying line width, now the line width is fixed.
  • The curved lines in the "K" didn't seem to follow a simple/obvious shape, they seemed somewhat arbitrarily curved. Assuming the image size of the monochrome PNG (800x258), I've derived them from the segment of a circle with radius 100 around (126,29) (top circle) and (126,229) (bottom circle).
  • The overall logo (rounded square + text) were not perfectly centered horizontally, I've moved the text a bit to the right, so it's centered now.
  • The font appears to be "Akrobat SemiBold" with negative letter spacing. I've used this font to re-create the text. There are some minor differences between the original text and the new one, in particular the dot of the "i" is now slightly higher.

I hope you like them despite the minor differences from the original logos.

@imjasonh
Copy link
Collaborator

Wow, thanks! I hadn't noticed those idiosyncrasies but now that you've pointed them out I can't unsee them either! 😆

I don't know where the original logo came from, to know whether these were intentional stylistic decisions, but I'm going to assume they weren't and just use these instead. Thanks for contributing the SVGs as well! 👍

@imjasonh imjasonh merged commit 31445e5 into GoogleContainerTools:main Mar 21, 2022
@sisp sisp deleted the svg-logo branch March 21, 2022 15:47
@sisp
Copy link
Contributor Author

sisp commented Mar 21, 2022

Awesome, I'm glad you like them. 🎉 Thanks for merging the PR so promptly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants