Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add test for issue #2049 #2114

Merged

Conversation

gabyx
Copy link
Contributor

@gabyx gabyx commented May 31, 2022

Add some more tests:
This missing files problem should be already fixed by PR #2066.

Fixes #2049

Description

Added a test to check existance of binary files.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

- This missing files problem should be fixed by PR GoogleContainerTools#2066.
@imjasonh imjasonh merged commit c13f9b6 into GoogleContainerTools:main Jun 1, 2022
@gabyx gabyx deleted the bugfix/add-more-missing-files-test branch June 2, 2022 19:36
@itscaro
Copy link

itscaro commented Nov 5, 2022

I'm using an image alpine with git and some wrapper scripts along with kaniko binary. When I build an image from alpine:

OK: binaries found in final image

apk add curl bash

KO: no binaries found in final image

apk add curl bash git

Something bugs with git?

I'm using kaniko image only, the two cases work well

@gabyx
Copy link
Contributor Author

gabyx commented Nov 5, 2022

Autsch, thats interesting. Can you post Docker example which raises the problem. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installed binaries are missing from image
3 participants