Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use refrence should after err handles #2128

Merged
merged 2 commits into from
Jun 9, 2022

Conversation

hingbong
Copy link
Contributor

@hingbong hingbong commented Jun 8, 2022

when I use kaniko as lib in my code, I don't know and set some options, and it doesn't handle error, just get a nil pointer panic.
should move the usage after err handling.

@google-cla
Copy link

google-cla bot commented Jun 8, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@hingbong
Copy link
Contributor Author

hingbong commented Jun 9, 2022

what do i need to do to fix these checks

pkg/executor/build.go Outdated Show resolved Hide resolved
@imjasonh
Copy link
Collaborator

imjasonh commented Jun 9, 2022

what do i need to do to fix these checks

There was a tiny lint finding, I commited a fix on your branch (hope that's okay). Once tests pass I'll merge it.

Thanks!

@imjasonh imjasonh merged commit 9f57952 into GoogleContainerTools:main Jun 9, 2022
@hingbong hingbong deleted the hingbong-patch-1 branch June 9, 2022 15:04
@hingbong
Copy link
Contributor Author

hingbong commented Jun 9, 2022

what do i need to do to fix these checks

There was a tiny lint finding, I commited a fix on your branch (hope that's okay). Once tests pass I'll merge it.

Thanks!

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants