Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to skip unpacking the initial file system #2234

Merged

Conversation

natalieparellano
Copy link
Contributor

Description

Add the ability to skip unpacking the initial file system

  • Adds a new option, InitialFSUnpacked
  • When opts.InitialFSUnpacked is true, the first stage builder will
    skip unpacking the file system; later stages are unaffected

Why do this:
This only makes sense if kaniko is used as a library, and the executor is running
in the context of an image that is the image referenced in the first FROM statement
in the Dockerfile. buildpacks.io is aiming to do this in order to customize base images
prior to buildpacks builds.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

Examples of user facing changes:
- kaniko adds a new flag `--registry-repo` to override registry

- Adds a new option, InitialFSUnpacked
- When opts.InitialFSUnpacked is true, the first stage builder will
  skip unpacking the file system; later stages are unaffected

Signed-off-by: Natalie Arellano <narellano@vmware.com>
@imjasonh imjasonh merged commit 76c0a8c into GoogleContainerTools:main Sep 6, 2022
@chuangw6 chuangw6 mentioned this pull request Sep 26, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants