Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light editing to scripts in hack/gofmt #2236

Merged

Conversation

MarkMoretto
Copy link
Contributor

Description

Just a couple of bash/shell script file edits to remove some duplicate lines.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

Examples of user facing changes:
- kaniko adds a new flag `--registry-repo` to override registry

Removed duplicate shebang interpreter directive: `#!/bin/bash`
Removed duplicate shebang interpreter directive.
@google-cla
Copy link

google-cla bot commented Sep 3, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@MarkMoretto
Copy link
Contributor Author

I think I signed a CLA. Not sure why it isn't clicking through.

@aaron-prindle
Copy link
Collaborator

Kicked the CLA job, all good now! Thanks for the PR @MarkMoretto!

@aaron-prindle aaron-prindle merged commit 0f40a81 into GoogleContainerTools:main May 19, 2023
kylecarbs pushed a commit to coder/kaniko that referenced this pull request Jul 12, 2023
* Update gofmt.sh

Removed duplicate shebang interpreter directive: `#!/bin/bash`

* Update boilerplate.sh

Removed duplicate shebang interpreter directive.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants