Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guide on creating multi-arch manifests #2306

Conversation

Jasper-Ben
Copy link
Contributor

While kaniko itself does not natively support building multi-arch container manifests, it may be used in combination with tools such as manifest-tool to create and merge seperate arch builds into a single manifest.

Fixes #1102
Fixes #786

Description

While kaniko itself does not natively support building multi-arch container manifests, it may be used in combination with tools such as manifest-tool to create and merge seperate arch builds into a single manifest.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

@aaron-prindle
Copy link
Collaborator

@Jasper-Ben thanks for the PR here! If you can rebase this, I'd be happy to review and get this in!

@eugenejen
Copy link

@Jasper-Ben do you need help on this PR to rebased it? I have vested interest to enable kaniko multiarch build so i will like to help.

@Jasper-Ben
Copy link
Contributor Author

@aaron-prindle @eugenejen
Hi! Sorry for the late reply, just didn't get around to it yet. Will rebase now 🙂

@Jasper-Ben Jasper-Ben force-pushed the document_multiarch_manifest branch 2 times, most recently from 89564d4 to 9ffc009 Compare June 2, 2023 15:58
While kaniko itself does not natively support building multi-arch
container manifests, it may be used in combination with tools such as
manifest-tool to create and merge seperate arch builds into a single
manifest.

Fixes GoogleContainerTools#1102
Fixes GoogleContainerTools#786
@Jasper-Ben Jasper-Ben force-pushed the document_multiarch_manifest branch from 9ffc009 to 5e7364c Compare June 2, 2023 16:00
@Jasper-Ben
Copy link
Contributor Author

Done.

I also noticed a missing toc entry, which I fixed in separate commit b097cd2

Feel free to cherry-pick into separate PR, if you so prefer 🙂

Copy link

@eugenejen eugenejen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LRTM

README.md Outdated Show resolved Hide resolved
@Jasper-Ben
Copy link
Contributor Author

Jasper-Ben commented Jun 6, 2023 via email

@aaron-prindle
Copy link
Collaborator

Thanks for updating the PR here @Jasper-Ben! Once the last fix you mentioned is in we can merge 🎊

@Jasper-Ben Jasper-Ben force-pushed the document_multiarch_manifest branch from b097cd2 to 06a6535 Compare June 7, 2023 08:22
@eugenejen
Copy link

@aaron-prindle can you look at the PR?

Copy link
Collaborator

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this @Jasper-Ben!

@aaron-prindle aaron-prindle merged commit cce5d31 into GoogleContainerTools:main Jun 7, 2023
kylecarbs pushed a commit to coder/kaniko that referenced this pull request Jul 12, 2023
* Add guide on creating multi-arch manifests

While kaniko itself does not natively support building multi-arch
container manifests, it may be used in combination with tools such as
manifest-tool to create and merge seperate arch builds into a single
manifest.

Fixes GoogleContainerTools#1102
Fixes GoogleContainerTools#786

* Add missing toc entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multi-arch manifest lists how to build multi-arch image using kaniko
3 participants