-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add guide on creating multi-arch manifests #2306
Add guide on creating multi-arch manifests #2306
Conversation
@Jasper-Ben thanks for the PR here! If you can rebase this, I'd be happy to review and get this in! |
@Jasper-Ben do you need help on this PR to rebased it? I have vested interest to enable kaniko multiarch build so i will like to help. |
@aaron-prindle @eugenejen |
89564d4
to
9ffc009
Compare
While kaniko itself does not natively support building multi-arch container manifests, it may be used in combination with tools such as manifest-tool to create and merge seperate arch builds into a single manifest. Fixes GoogleContainerTools#1102 Fixes GoogleContainerTools#786
9ffc009
to
5e7364c
Compare
Done. I also noticed a missing toc entry, which I fixed in separate commit b097cd2 Feel free to cherry-pick into separate PR, if you so prefer 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LRTM
Good catch! Thats on me. Doctoc kept changing the document layout for me, so I changed this part manually. Will push a fix tomorrow.
|
Thanks for updating the PR here @Jasper-Ben! Once the last fix you mentioned is in we can merge 🎊 |
b097cd2
to
06a6535
Compare
@aaron-prindle can you look at the PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for this @Jasper-Ben!
* Add guide on creating multi-arch manifests While kaniko itself does not natively support building multi-arch container manifests, it may be used in combination with tools such as manifest-tool to create and merge seperate arch builds into a single manifest. Fixes GoogleContainerTools#1102 Fixes GoogleContainerTools#786 * Add missing toc entry
While kaniko itself does not natively support building multi-arch container manifests, it may be used in combination with tools such as manifest-tool to create and merge seperate arch builds into a single manifest.
Fixes #1102
Fixes #786
Description
While kaniko itself does not natively support building multi-arch container manifests, it may be used in combination with tools such as manifest-tool to create and merge seperate arch builds into a single manifest.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes