Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #2537 - index out of range #2538

Closed
wants to merge 1 commit into from

Conversation

Gnoale
Copy link

@Gnoale Gnoale commented May 29, 2023

Fixes #2537

Description

It seems that the addendums slice index is incremented twice in cases there is an empty layer in the history

I am not sure to understand what I am doing but here is an attempt to fix it :)

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

Examples of user facing changes:
- kaniko adds a new flag `--registry-repo` to override registry

@google-cla
Copy link

google-cla bot commented May 29, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Gnoale Gnoale changed the title #2537 - fix index out of range ? fix: #2537 - index out of range May 29, 2023
@aaron-prindle
Copy link
Collaborator

aaron-prindle commented May 29, 2023

Thanks for the PR here @Gnoale, the change you have made here is actually a change against the https://github.com/google/go-containerregistry project. Can you submit this PR there stating that it fixes google/go-containerregistry#1646? Going to close this PR as it is actually an issue with the go-containerregistry library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reproducible cause panic
2 participants