Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update google-github-actions/setup-gcloud to v1.1.1 #2548

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

ferrastas
Copy link
Contributor

Description

On the latest google-github-actions/setup-gcloud versions, the auth mechanism has been removed and google-github-actions/auth needs to be used instead.

Fixes #2525

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

On the latest `google-github-actions/setup-gcloud` versions, the auth mechanism has been removed and `google-github-actions/auth` needs to be used instead.

Closes GoogleContainerTools#2525

Signed-off-by: Ferran Vidal <ferran.vidal.p@gmail.com>
@ferrastas
Copy link
Contributor Author

@aaron-prindle this should fix the broken GitHub Action

Copy link
Collaborator

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix here @ferrastas! LGTM

@aaron-prindle aaron-prindle merged commit c1436d4 into GoogleContainerTools:main Jun 7, 2023
kylecarbs pushed a commit to coder/kaniko that referenced this pull request Jul 12, 2023
On the latest `google-github-actions/setup-gcloud` versions, the auth mechanism has been removed and `google-github-actions/auth` needs to be used instead.

Closes GoogleContainerTools#2525

Signed-off-by: Ferran Vidal <ferran.vidal.p@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump google-github-actions/setup-gcloud from 0.5.1 to 1.1.1
2 participants