use aws-sdk-go-v2 #2550
Merged
use aws-sdk-go-v2 #2550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: BobDu <i@bobdu.cc>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
aaron-prindle
approved these changes
Jun 7, 2023
There was a problem hiding this comment.
LGTM! Thanks for updating this @BobDu! Seems this reduces the kaniko/executor binary size by ~10% 🎊
Before PR: 39M
After PR: 35M
kylecarbs
pushed a commit
to coder/kaniko
that referenced
this pull request
Jul 12, 2023
Signed-off-by: BobDu <i@bobdu.cc>
liam-verta
added a commit
to VertaAI/kaniko
that referenced
this pull request
Jul 17, 2023
This reverts commit d54caaa.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aws go sdk v2 use a separate module for each service, use it to optimize the binary size
Description
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes
Describe any changes here so maintainer can include it in the release notes, or delete this block.