fix: resolve issue where warmer CLI always validated optional arg -> breakage for majority of users #2603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…breakage for majority of users
|
I'm not really familiar with Go , but this looks correct to me. I was suspecting that the default value was in charge of the mess , but I see the validation improved as well. So 👍 from me. |
chuangw6
approved these changes
Jun 29, 2023
kylecarbs
pushed a commit
to coder/kaniko
that referenced
this pull request
Jul 12, 2023
…breakage for majority of users (GoogleContainerTools#2603)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2602
Resolves bug in PR #2499 in which the Dockerfile path is always set by default (and thus never empty -
"") as well as always validated even when the--dockerfileflag is not supplied -> validation error which breaks normal usage of passing--imageflag only.