Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment variables with multiple '=' are not parsed correctly #278

Conversation

AndreaGiardini
Copy link
Contributor

This pull request provides a failing integration test.

Whenever a Dockerfile contains an environment variable (ENV) with multiple = the final image contains an env variable with a stripped-down version of the content.

It would be nice if somebody could point me in the right direction to fix this problem :)

Thanks

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@AndreaGiardini
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@AndreaGiardini
Copy link
Contributor Author

A failing test case and the fix have been provided :)

@AndreaGiardini AndreaGiardini changed the title Provide failing test for an env variable with multiple '=' Environment variables with multiple '=' are not parsed correctly Aug 7, 2018
@priyawadhwa
Copy link
Collaborator

Thanks for fixing this!

@priyawadhwa priyawadhwa merged commit c44c317 into GoogleContainerTools:master Aug 7, 2018
@AndreaGiardini AndreaGiardini deleted the envVariableWithMultipleEquals branch August 7, 2018 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants