Skip the /kaniko directory when copying root #2863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the skip option for otiai10.Copy to skip the /kaniko directory when the root is being copied. The files under /kaniko dir should be ignored and thus this shall not cause any loss of information. fixes: GoogleContainerTools#2033
JeromeJu
force-pushed
the
2033-otaicopy
branch
from
9a96d4b
to
6b0531f
Compare
| FROM busybox:1.31 | ||
| COPY context/foo foo | ||
|
|
||
| FROM alpine@sha256:5ce5f501c457015c4b91f91a15ac69157d9b06f1a75cf9107bf2b62e0843983a |
There was a problem hiding this comment.
I don't have full context, but could you help explain how does this dockerfile tests the logic change?
There was a problem hiding this comment.
Also, is the release note related to the PR?
There was a problem hiding this comment.
I don't have full context, but could you help explain how does this dockerfile tests the logic change?
Prior to this change, when the source "/" is specified, we will see errors described at #2033 (comment) with recursive /kaniko/0 in the names. This test case test copying from root and the kaniko/0 folder shall not be apparent.
I also added a sentence for the previous situation in the message. Thanks for pointing this out.
aaron-prindle
approved these changes
Nov 29, 2023
This was referenced Nov 29, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, the files under the
/kanikodir is also attempted to be copied. This commit adds the skip option for otiai10.Copy to skip the /kaniko directory when the root is being copied. The files under /kaniko dir should be ignored and thus this shall not cause any loss of information.fixes: #2033
Description
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes