Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: also update github.com/awslabs/amazon-ecr-credential-helper to resolve issues with AWS ECR authentication (resolves #2882) #2908

Merged
merged 1 commit into from
Dec 15, 2023
Merged

fix: also update github.com/awslabs/amazon-ecr-credential-helper to resolve issues with AWS ECR authentication (resolves #2882) #2908

merged 1 commit into from
Dec 15, 2023

Conversation

pdecat
Copy link
Contributor

@pdecat pdecat commented Dec 15, 2023 •
edited
Loading

Resolves #2882.

This is basically:

# git checkout main
# go get -u github.com/awslabs/amazon-ecr-credential-helper/...
# go mod tidy
# go mod vendor
# git add -A

Signed-off-by: Patrick Decat pdecat@gmail.com

@pdecat pdecat mentioned this pull request Dec 15, 2023
Closed
@pdecat
fix: also update github.com/awslabs/amazon-ecr-credential-helper to r…
525ec33 
…esolve issues with AWS ECR authentication

As mentioned in aws/aws-sdk-go-v2#2370, AWS
SDK for Go v2 releases after 2023/11/15 broke compatibility with all
previous releases.

Resolves GoogleContainerTools#2882

Signed-off-by: Patrick Decat <pdecat@gmail.com>
@aaron-prindle
Copy link
Collaborator

Thank you @pdecat for the fix PR here! Going to validate the fix with other folks in the #2882 thread before closing and then we should be able to release a new patch version Kaniko that is stable for AWS ECR users 🎊

@aaron-prindle aaron-prindle merged commit a946b82 into GoogleContainerTools:main Dec 15, 2023
10 checks passed
This was referenced Dec 15, 2023
Closed
Merged
@pdecat pdecat deleted the fix/aws_ecr branch January 16, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaron-prindle aaron-prindle aaron-prindle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWS ECR build permissions issue with Kaniko v1.19.0 & v1.19.1 (found using v1.19.0-debug & v1.19.1-debug)
2 participants
@pdecat @aaron-prindle