Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate --insecure-skip-tls-verify flag into two separate flags #311

Conversation

DerDackel
Copy link
Contributor

Possibly fixes #310

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@container-tools-bot
Copy link
Collaborator

Hi @DerDackel. Thanks for your PR.

I'm waiting for a GoogleContainerTools member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@DerDackel DerDackel force-pushed the separate-insecure-from-tls-verify branch 2 times, most recently from 1bfee74 to ab7c5b5 Compare August 24, 2018 14:32
@googlebot
Copy link

CLAs look good, thanks!

Copy link
Collaborator

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! This looks good to me overall, could you also update the README to include these flags in the Additional Flags section?

SrcContext string
SnapshotMode string
Bucket string
DockerInsecure bool
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we rename DockerInsecure to something which doesn't include Docker in the name, maybe InsecurePush?

@DerDackel
Copy link
Contributor Author

Done and done. I took the liberty of adding a warning about their intended use to both flags.

@priyawadhwa
Copy link
Collaborator

Thanks! I think you just have to rebase against master and this should be good.

@DerDackel DerDackel force-pushed the separate-insecure-from-tls-verify branch from af28a48 to 1a7de69 Compare August 30, 2018 07:37
@dlorenc
Copy link
Collaborator

dlorenc commented Aug 30, 2018

/lgtm

Copy link
Collaborator

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this!

@priyawadhwa priyawadhwa merged commit 9cc1d27 into GoogleContainerTools:master Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--insecure-skip-tls-verify forces plain HTTP making the skip-tls-verify part confusing
6 participants