Speedup --reproducible layer stripping #3347
Conversation
Fixes GoogleContainerTools#862, may mitigate GoogleContainerTools#1960 The layerTime function returns a layer backed by an in-memory buffer, which means during the stripping of timestamps the entire image is loaded into memory. Additionally, it runs gzip after the layer is created, resulting in even an even larger in-memory blob. This commit changes this method to use a temporary file instead of an in-memory buffer, and to use gzip compression while writing to this layer file, instead of compressing during read. Signed-off-by: bh <bert@transtrend.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Signed-off-by: bh <bert@transtrend.com>
|
Note: the temporary files created by kaniko are not cleaned up, I'm not sure if this is necessary given that kaniko is designed to run in a container. If it is, is there some kind of lifecycle method that can be called to clean the files, preferably through the v1.Layer struct? |
|
I'm a developer working at a company so it may take some time before I can get the CLA signed... |
|
Hmm should I submit this here or in go-containerregistry? |
Fixes #862, may mitigate #1960
The layerTime function returns a layer backed by an in-memory buffer, which means during the stripping of timestamps the entire image is loaded into memory. Additionally, it runs gzip after the layer is created, resulting in even an even larger in-memory blob.
This commit changes this method to use a temporary file instead of an in-memory buffer, and to use gzip compression while writing to this layer file, instead of compressing during read.
Fixes #862, may mitigate #1960
Description
This commit changes the layerTime method to use a temporary file instead of an in-memory buffer, and to use gzip compression while writing to this layer file, instead of compressing during read.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Covered by existing unit tests, single method change. Integration tests not necessary.
See the contribution guide for more details.
Reviewer Notes
Release Notes
Describe any changes here so maintainer can include it in the release notes, or delete this block.