Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More cache cleanups: #397

Merged
merged 1 commit into from
Nov 1, 2018
Merged

More cache cleanups: #397

merged 1 commit into from
Nov 1, 2018

Conversation

dlorenc
Copy link
Collaborator

@dlorenc dlorenc commented Oct 15, 2018

  • move the layer cache to an interface
  • refactor the DockerCommand implementations to support Cached and non-cached implementations.

@dlorenc dlorenc force-pushed the cacheinterface branch 3 times, most recently from 9c849e6 to 546be4b Compare October 18, 2018 23:09
@dlorenc
More cache cleanups:
03cfb21 
- move the layer cache to an interface
- refactor the DockerCommand implementations to support Cached and non-cached implementations.
@dlorenc
Copy link
Collaborator Author

dlorenc commented Oct 31, 2018

This should be ready for review now! cc @priyawadhwa @sharifelgamal

@dlorenc dlorenc merged commit 52a6ce6 into GoogleContainerTools:master Nov 1, 2018
@dlorenc dlorenc deleted the cacheinterface branch November 1, 2018 16:11
@dlorenc dlorenc mentioned this pull request Nov 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharifelgamal sharifelgamal sharifelgamal approved these changes

@priyawadhwa priyawadhwa priyawadhwa approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dlorenc @priyawadhwa @sharifelgamal @container-tools-bot